jrhea commented on a change in pull request #24: Move to hobbits 3 with binary messages URL: https://github.com/apache/incubator-tuweni/pull/24#discussion_r301698718
########## File path: hobbits/src/main/kotlin/org/apache/tuweni/hobbits/Message.kt ########## @@ -16,18 +16,20 @@ */ package org.apache.tuweni.hobbits -import com.google.common.base.Splitter import org.apache.tuweni.bytes.Bytes -import java.nio.charset.StandardCharsets +import java.lang.IllegalArgumentException +import java.nio.ByteBuffer +import java.nio.charset.StandardCharsets.UTF_8 +val PREAMBLE = "EWP".toByteArray(UTF_8) +val MESSAGE_HEADER_LENGTH = PREAMBLE.size + java.lang.Integer.BYTES * 3 + 1 Review comment: this confused me for a sec, but looks good ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
