To make it more explicit, I checked the box “pre-release” on it. Please let me know if that helps remove confusion.
> On Oct 1, 2019, at 5:23 PM, Antoine Toulme <[email protected]> wrote: > > It’s a git tag. You can see it noted in my first email to the thread. > >> On Oct 1, 2019, at 5:14 PM, Michael Wall <[email protected]> wrote: >> >> Hi Vinay, >> >> I take the following to mean releases are allowed on github after >> dist.apache.org >> http://www.apache.org/legal/release-policy.html#release-distribution >> >> However, I do think the 0.9.0 is violating >> http://www.apache.org/legal/release-policy.html#publication since they have >> not been voted on. There can be no official release in dist.apache.org. >> >> Antoine, how did the 0.9.0 releases end up on github? >> >> Mike >> >> On Tue, Oct 1, 2019 at 3:29 AM Vinayakumar B <[email protected]> >> wrote: >> >>> I was going through the releases page in github >>> https://github.com/apache/incubator-tuweni/releases. >>> >>> Are we allowed to release in github? >>> shouldn't be only on dist.apache.org? >>> >>> Already 0.9.0 release shows up in above page, though without any >>> description. >>> >>> I will take a detailed look at artifacts later today. >>> >>> -Vinay >>> >>> >>> On Tue, Oct 1, 2019 at 8:36 AM Michael Wall <[email protected]> wrote: >>> >>>> I can look at these tomorrow. Are we all voting on the same things here? >>>> The original email says we are voting on just the source distributions. >>> So >>>> is that tuwnei-src only? I notice Dave's vote checked all 8 packages >>> (zip >>>> and tgz for tuweni-bin, tuweni-gossip, tuweni-relay and tuweni-src.). I >>>> think it is confusing to have these other artifacts in there, unless we >>> are >>>> voting on those as well. >>>> >>>> Mike >>>> >>>> >>>> >>>> On Sun, Sep 29, 2019 at 12:32 PM Antoine Toulme <[email protected]> >>>> wrote: >>>> >>>>> I’ll reply to all your questions, promised. Can we get one more mentor >>>>> vote? >>>>> >>>>>> On Sep 27, 2019, at 11:04, Furkan KAMACI <[email protected]> >>>> wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> +1 from me. >>>>>> >>>>>> I checked: >>>>>> - Incubating in name >>>>>> - DISCLAIMER exists >>>>>> - LICENSE and NOTICE are fine >>>>>> - No unexpected binary files >>>>>> - Checked PGP signatures >>>>>> - Checked Checksums >>>>>> - Code compiles >>>>>> >>>>>> I've to comments: >>>>>> >>>>>> 1) How do you get shasum? >>>>>> >>>>>> 2) I've got an error at tests but it may be specific to my >>> environment: >>>>>> >>>>>> tuweni-src-0.9.0 java -version >>>>>> >>>>>> java version "1.8.0_102" >>>>>> Java(TM) SE Runtime Environment (build 1.8.0_102-b14) >>>>>> Java HotSpot(TM) 64-Bit Server VM (build 25.102-b14, mixed mode) >>>>>> >>>>>> uname -a >>>>>> Darwin MacBook-Pro.local 18.6.0 Darwin Kernel Version 18.6.0: Thu Apr >>>> 25 >>>>>> 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64 x86_64 >>>>>> >>>>>> Error log: >>>>>> >>>>>> org.opentest4j.AssertionFailedError: Should have contained 14 items, >>>> but >>>>>> got 15: >>>>>> >>>>>> >>>>> >>>> >>> file:/var/folders/61/6c56k1sj7s5_gxgj6h6930h80000gn/T/ResourcesTest3388616531682973533/org/apache/tuweni/io/file/resourceresolver/ >>>>>> >>>>>> >>>>> >>>> >>> file:/var/folders/61/6c56k1sj7s5_gxgj6h6930h80000gn/T/ResourcesTest3388616531682973533/org/apache/tuweni/io/file/resourceresolver/test1.txt >>>>>> >>>>>> >>>>> >>>> >>> file:/var/folders/61/6c56k1sj7s5_gxgj6h6930h80000gn/T/ResourcesTest3388616531682973533/org/apache/tuweni/io/file/resourceresolver/test2.txt >>>>>> >>>>>> >>>>> >>>> >>> file:/var/folders/61/6c56k1sj7s5_gxgj6h6930h80000gn/T/ResourcesTest3388616531682973533/org/apache/tuweni/io/file/resourceresolver/subdir/ >>>>>> >>>>>> >>>>> >>>> >>> file:/var/folders/61/6c56k1sj7s5_gxgj6h6930h80000gn/T/ResourcesTest3388616531682973533/org/apache/tuweni/io/file/resourceresolver/subdir/test3.yaml >>>>>> >>>>>> >>>>> >>>> >>> file:/var/folders/61/6c56k1sj7s5_gxgj6h6930h80000gn/T/ResourcesTest3388616531682973533/org/apache/tuweni/io/file/resourceresolver/test.txt >>>>>> >>>>>> >>>>> >>>> >>> jar:file:/var/folders/61/6c56k1sj7s5_gxgj6h6930h80000gn/T/ResourcesTest3388616531682973533/resourceresolvertest.jar!/ >>>>>> >>>>>> >>>>> >>>> >>> jar:file:/var/folders/61/6c56k1sj7s5_gxgj6h6930h80000gn/T/ResourcesTest3388616531682973533/resourceresolvertest.jar!/test1.txt >>>>>> >>>>>> >>>>> >>>> >>> jar:file:/var/folders/61/6c56k1sj7s5_gxgj6h6930h80000gn/T/ResourcesTest3388616531682973533/resourceresolvertest.jar!/test2.txt >>>>>> >>>>>> >>>>> >>>> >>> jar:file:/var/folders/61/6c56k1sj7s5_gxgj6h6930h80000gn/T/ResourcesTest3388616531682973533/resourceresolvertest.jar!/subdir/ >>>>>> >>>>>> >>>>> >>>> >>> jar:file:/var/folders/61/6c56k1sj7s5_gxgj6h6930h80000gn/T/ResourcesTest3388616531682973533/resourceresolvertest.jar!/subdir/test3.yaml >>>>>> >>>>>> >>>>> >>>> >>> jar:file:/var/folders/61/6c56k1sj7s5_gxgj6h6930h80000gn/T/ResourcesTest3388616531682973533/resourceresolvertest.jar!/anotherdir/ >>>>>> >>>>>> >>>>> >>>> >>> jar:file:/var/folders/61/6c56k1sj7s5_gxgj6h6930h80000gn/T/ResourcesTest3388616531682973533/resourceresolvertest.jar!/anotherdir/test5.txt >>>>>> >>>>>> >>>>> >>>> >>> jar:file:/var/folders/61/6c56k1sj7s5_gxgj6h6930h80000gn/T/ResourcesTest3388616531682973533/resourceresolvertest.jar!/anotherdir/test6.yaml >>>>>> >>>>>> >>>>> >>>> >>> jar:file:/var/folders/61/6c56k1sj7s5_gxgj6h6930h80000gn/T/ResourcesTest3388616531682973533/resourceresolvertest.jar!/test.txt >>>>>> ==> expected: <14> but was: <15> >>>>>> at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:54) >>>>>> at >>>> org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:199) >>>>>> at >>>> org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:158) >>>>>> at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:342) >>>>>> at >>>>>> org.apache.tuweni.io >>>>> >>>> >>> .ResourcesTest.shouldIterateResourcesOnFileSystemAndInJars(ResourcesTest.java:98) >>>>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>>>>> at >>>>>> >>>>> >>>> >>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) >>>>>> at >>>>>> >>>>> >>>> >>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>>> at java.lang.reflect.Method.invoke(Method.java:498) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:532) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:115) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$6(TestMethodTestDescriptor.java:171) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:72) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:167) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:114) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:59) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$4(NodeTestTask.java:108) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:72) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:98) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:74) >>>>>> at java.util.ArrayList.forEach(ArrayList.java:1249) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$4(NodeTestTask.java:112) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:72) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:98) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:74) >>>>>> at java.util.ArrayList.forEach(ArrayList.java:1249) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$4(NodeTestTask.java:112) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:72) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:98) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:74) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:32) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:220) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.launcher.core.DefaultLauncher.lambda$execute$6(DefaultLauncher.java:188) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.launcher.core.DefaultLauncher.withInterceptedStreams(DefaultLauncher.java:202) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:181) >>>>>> at >>>>>> >>>>> >>>> >>> org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:128) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.processAllTestClasses(JUnitPlatformTestClassProcessor.java:94) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.access$100(JUnitPlatformTestClassProcessor.java:79) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor.stop(JUnitPlatformTestClassProcessor.java:75) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:61) >>>>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>>>>> at >>>>>> >>>>> >>>> >>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) >>>>>> at >>>>>> >>>>> >>>> >>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>>> at java.lang.reflect.Method.invoke(Method.java:498) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93) >>>>>> at com.sun.proxy.$Proxy2.stop(Unknown Source) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.api.internal.tasks.testing.worker.TestWorker.stop(TestWorker.java:132) >>>>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>>>>> at >>>>>> >>>>> >>>> >>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) >>>>>> at >>>>>> >>>>> >>>> >>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>>> at java.lang.reflect.Method.invoke(Method.java:498) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:175) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:157) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:404) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46) >>>>>> at >>>>>> >>>>> >>>> >>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) >>>>>> at >>>>>> >>>>> >>>> >>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) >>>>>> at >>>>>> >>>>> >>>> >>> org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55) >>>>>> at java.lang.Thread.run(Thread.java:745) >>>>>> >>>>>> Kind Regards, >>>>>> Furkan KAMACI >>>>>> >>>>>>> On Fri, Sep 27, 2019 at 12:01 AM Dave Fisher <[email protected]> >>> wrote: >>>>>>> >>>>>>> +1 (binding) >>>>>>> >>>>>>> Checked all eight packages signatures and checksums. >>>>>>> Diffed the unpacked version of tgz and zip to assure they were >>>>> equivalent. >>>>>>> Checked DISCLAIMER >>>>>>> Checked NOTICE >>>>>>> Checked LICENSE >>>>>>> Reviewed README files - there is a minor nonblocking issue - see >>>> below. >>>>>>> No unexpected binary in Source Release >>>>>>> Built from scratch - one test failed - >>>>>>> shouldIterateResourcesOnFileSystemAndInJars(Path) >>>>>>> Ratcheck passed - I believe that the licenses for the Etherium test >>>>> suite >>>>>>> is properly called out in LICENSE. >>>>>>> >>>>>>> >>>>>>> The README.md file mentions the Jenkins build server and >>>>>>> repository.apache.org. Apache projects should not be sharing these >>> as >>>>>>> part of a release. These are development resources that can be >>> shared >>>>>>> within the developer community here on the mailing list. >>>>>>> >>>>>>> I’ve seen numerous organizations get locked out of apache.org >>> access >>>>> for >>>>>>> abuse of repository.apache.org. This abuse could be a large number >>> of >>>>>>> developers building with repository.apache.org as one of their >>>>>>> repositories. Users should be going to maven central. >>>>>>> >>>>>>> See this note from Release Policy. [1] >>>>>>> >>>>>>> Regards, >>>>>>> Dave >>>>>>> >>>>>>> [1] http://www.apache.org/legal/release-policy.html#host-rc >>>>>>> >>>>>>>> On Sep 25, 2019, at 6:23 PM, Antoine Toulme <[email protected]> >>>>> wrote: >>>>>>>> >>>>>>>> We're voting on the source distributions available here: >>>>>>>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.9.0/ >>>>>>>> The release tag is present here: >>>>>>>> https://github.com/apache/incubator-tuweni/releases/tag/v0.9.0 >>>>>>>> >>>>>>>> Please review and vote as appropriate. >>>>>>>> >>>>>>>> The following changes were made since 0.8.2: >>>>>>>> * Scuttlebutt improvements: we now support calling the social >>> graphs >>>>> and >>>>>>> additional RPC methods. >>>>>>>> * Hobbits v3 support: we use binary messages. >>>>>>>> * SSZ improvements for homogeneous types >>>>>>>> >>>>>>>> Cheers, >>>>>>>> >>>>>>>> Antoine >>>>>>>> >>>>>>>> >>>>>>>> >>> --------------------------------------------------------------------- >>>>>>>> To unsubscribe, e-mail: [email protected] >>>>>>>> For additional commands, e-mail: [email protected] >>>>>>>> >>>>>>> >>>>>>> >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: [email protected] >>>>> For additional commands, e-mail: [email protected] >>>>> >>>>> >>>> >>> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
