+1 binding - signatures look good for all 8 artifacts - gradle setup && ./gradlew build succeeded - DISCLAIMER, NOTICE and LICENSE good - Noted some jars in the tuweni-bin/lib directory have .asc files, some do not.
Thanks Mike On Tue, Oct 1, 2019 at 9:02 PM Antoine Toulme <[email protected]> wrote: > > > > On Sep 26, 2019, at 2:01 PM, Dave Fisher <[email protected]> wrote: > > > > +1 (binding) > > > > Checked all eight packages signatures and checksums. > > Diffed the unpacked version of tgz and zip to assure they were > equivalent. > > Checked DISCLAIMER > > Checked NOTICE > > Checked LICENSE > > Reviewed README files - there is a minor nonblocking issue - see below. > > No unexpected binary in Source Release > > Built from scratch - one test failed - > shouldIterateResourcesOnFileSystemAndInJars(Path) > > Ratcheck passed - I believe that the licenses for the Etherium test > suite is properly called out in LICENSE. > > > > > > The README.md file mentions the Jenkins build server and > repository.apache.org. Apache projects should not be sharing these as > part of a release. These are development resources that can be shared > within the developer community here on the mailing list. > > > > I’ve seen numerous organizations get locked out of apache.org access > for abuse of repository.apache.org. This abuse could be a large number of > developers building with repository.apache.org as one of their > repositories. Users should be going to maven central. > > > > See this note from Release Policy. [1] > Good point, and now 0.8.2 really made it to Maven Central, so I can > actually recommend that. > > > > Regards, > > Dave > > > > [1] http://www.apache.org/legal/release-policy.html#host-rc > > > >> On Sep 25, 2019, at 6:23 PM, Antoine Toulme <[email protected]> > wrote: > >> > >> We're voting on the source distributions available here: > >> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.9.0/ > >> The release tag is present here: > >> https://github.com/apache/incubator-tuweni/releases/tag/v0.9.0 > >> > >> Please review and vote as appropriate. > >> > >> The following changes were made since 0.8.2: > >> * Scuttlebutt improvements: we now support calling the social graphs > and additional RPC methods. > >> * Hobbits v3 support: we use binary messages. > >> * SSZ improvements for homogeneous types > >> > >> Cheers, > >> > >> Antoine > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
