Apologies for late response.
I checked,
- Incubating in name - Fine.
- LICENCE and DISCLAIMER exists - Fine
- Checked PGP signatures - Fine (Suggestion: Maybe better give option
to download public keys of release owners in website, instead of users
finding them in public servers)
- Checked checksums - Fine (Suggestion: .sha512 file contains just
sha512 hash alone. Validation would be easy using tools (sha512sum
--verify) if the format of .sha512 contents is similar to output "sha512
--tag <file-name>" )
- Checked tag in github - I think, directly tagging with release
version name (v1.2.0-incubating) and linking all dists, while still VOTE is
in progress may not be good. Its better to tag with RC labels, not give an
impression that its already released.
- Tried building from src tar - Generated libs have SNAPSHOT version in
their name. This might not be correct. I saw that only during
BUILD_RELEASE=true or BUILD_TIMESTAMP=true, SNAPSHOT will be avoided. I
think, on the development version SNAPSHOT should be there by default and
on the released version SNAPSHOT should be removed irrespective of whether
publishing to maven or not.
All above points mentioned are not blockers for this release. But they are
something better to be taken care of for upcoming versions.
+1 ,
Thanks,
-Vinay
On Sun, Sep 27, 2020 at 8:02 AM Antoine Toulme <[email protected]> wrote:
> I’m worried there’s no one with time or interest to vote here. Please let
> me know?
>
> > On Sep 23, 2020, at 10:07 PM, Antoine Toulme <[email protected]>
> wrote:
> >
> > We need one more vote. Anyone with a bit of time to vote?
> >
> >> On Sep 21, 2020, at 5:21 AM, Furkan KAMACI <[email protected]>
> wrote:
> >>
> >> Hi,
> >>
> >> +1 from me.
> >>
> >> I checked:
> >>
> >> - Incubating in name
> >> - DISCLAIMER exists
> >> - LICENSE and NOTICE are fine
> >> - No unexpected binary files
> >> - Checked PGP signatures
> >> - Checked checksums
> >> - Code compiles
> >>
> >> Kind Regards,
> >> Furkan KAMACI
> >>
> >> On Sun, Sep 20, 2020 at 1:38 AM Antoine Toulme <[email protected]>
> wrote:
> >>
> >>> Bump - anyone with time to vote?
> >>>
> >>>> Begin forwarded message:
> >>>>
> >>>> From: Antoine Toulme <[email protected]>
> >>>> Subject: Re: [VOTE] Tuweni 1.2.0-incubating release
> >>>> Date: September 17, 2020 at 12:53:04 AM PDT
> >>>> To: [email protected]
> >>>>
> >>>> +1 from me.
> >>>> I checked and signatures match.
> >>>> The distribution contents are as expected.
> >>>>
> >>>>> On Sep 14, 2020, at 11:54 PM, Antoine Toulme <[email protected]>
> >>> wrote:
> >>>>>
> >>>>> We're voting on the source distributions available here:
> >>>>>
> >>>
> https://dist.apache.org/repos/dist/dev/incubator/tuweni/1.2.0-incubating/
> >>>>> The release tag is present here:
> >>>>>
> >>>
> https://github.com/apache/incubator-tuweni/releases/tag/v1.2.0-incubating
> >>>>>
> >>>>> This release includes the following changes:
> >>>>> New:
> >>>>> * Ethash hashing support
> >>>>> * EVMC support
> >>>>> * Simplify distribution down to one binary and source artifacts
> >>>>> * Added doc build
> >>>>> Changes:
> >>>>> * Refactor discv5, testing it with an eth2 client
> >>>>> * Simplified and streamlined LES to match ETH devp2p subprotocols
> >>>>> Bug fixes:
> >>>>> * Fixes #141 - Generated Maven pom.xml have incorrect information
> >>>>> * Fix SecureScuttlebutt setup.
> >>>>> Misc:
> >>>>> * Added codecov and tests adding coverage
> >>>>>
> >>>>>
> >>>>
> >>>
> >>>
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>
