-1 - Some breakages that makes it non-drop-in compatbiel with 1.3.0

* The POMs have errors, the artifactId is <foo> but they depend on each
other as tuweni-<foo>.  I have a mild preference for global tuweni-<foo> to
reduce jar collisions.  Looks like some tweaks to cope with gradle 6.x
changes introduced this.

* There are incompatible API changes.  whitelist->allowlist should have
deprecated and left in whitelist.  Also, a missing DNSDaemon constructor
and a change to the associated listen has a void return now.  The listener
changes is fine, but I would have expected that as part of a 2.0.  If there
are a number of these API changes a 2.0 may be a better approach.

* Some bytes32 changes broke stuff...
  @Test
  void testLong() {
      Wei.valueOf(100L).toLong();
  }
doesn't work but I expect it too.  There are 31 bytes of zeros I expect
toLong to happily trim off.

There may be more breakages, but this is enough to pull the brake on the
train.

On Thu, May 27, 2021 at 9:05 AM nicolas melendez <nfmelen...@gmail.com>
wrote:

> +1
>
> Executed all the executables in ./bin
>
> Tuweni started, created the server and could see the UI
> Gossip started, all seems good
> Eth-faucet started, i have to config it better would be nice to have a
> default config there if possible
> Crawler started, need to configure it better
> hobbit-relayer, started seems good.
> scraper started, seems good
> v4scraper started, seems good.
>
> LGTM
>
>
>
>
>
>
>
> El mié, 26 may 2021 a las 4:45, Antoine Toulme (<anto...@toulme.name>)
> escribió:
>
> > We're voting on the source distributions available here:
> >
> https://dist.apache.org/repos/dist/dev/incubator/tuweni/1.4.0-incubating/
> > The release tag is present here:
> >
> >
> https://github.com/apache/incubator-tuweni/releases/tag/v1.4.0-incubating-rc
> >
> > This release includes the following changes:
> >
> > Features:
> > * Users can select to keep select connections to other peers alive,
> > reconnecting on disconnection (RLPx)
> > * New faucet application, with a simple wallet.
> > * JSON-RPC client and server (server is just started)
> > * Add syncing capabilities for mainnet
> > * Cache hashcode on Bytes objects.
> > * Use one binary bistro, and one Docker image for all of Tuweni.
> > * Implement the EVM as Kotlin code, instead of importing EVMC
> > * Add ethstats server
> > * Add network crawler
> > * Add proxy subprotocol
> > * Add support for eth/66 (RLPx)
> >
> > Fixes:
> > * DNS daemon no longer throws errors when it cannot communicate over TCP
> > * NOTICE for binary distro
> > * #168: Fix Bytes32.wrap with offset
> > * Remove biased language (allowlist, main branch)
> >
> > Cheers,
> >
> > Antoine
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@tuweni.apache.org
> > For additional commands, e-mail: dev-h...@tuweni.apache.org
> >
> >
>
> --
>
> *NMNicolás Meléndez*
> *blog.melendez.com.ar  <http://blog.melendez.com.ar>*
>

Reply via email to