sudo-update commented on a change in pull request #274:
URL: https://github.com/apache/incubator-tuweni/pull/274#discussion_r650563269
##########
File path:
eth-repository/src/main/kotlin/org/apache/tuweni/eth/repository/BlockchainIndex.kt
##########
@@ -553,16 +550,16 @@ class BlockchainIndex(private val indexWriter:
IndexWriter) : BlockchainIndexWri
val topDocs = searcher!!.search(
TermQuery(Term("_type", "difficulty")),
- 10,
+ HITS,
Sort(SortField(TOTAL_DIFFICULTY.fieldName, SortField.Type.STRING,
true))
)
-
- for (hit in topDocs.scoreDocs) {
- val doc = searcher.doc(hit.doc, setOf("_id"))
- val bytes = doc.getBinaryValue("_id")
+ val doc = searcher.doc(topDocs.scoreDocs.elementAt(0).doc, setOf("_id"))
Review comment:
### Looking into it now
##########
File path:
eth-repository/src/main/kotlin/org/apache/tuweni/eth/repository/BlockchainIndex.kt
##########
@@ -553,16 +550,16 @@ class BlockchainIndex(private val indexWriter:
IndexWriter) : BlockchainIndexWri
val topDocs = searcher!!.search(
TermQuery(Term("_type", "difficulty")),
- 10,
+ HITS,
Sort(SortField(TOTAL_DIFFICULTY.fieldName, SortField.Type.STRING,
true))
)
-
- for (hit in topDocs.scoreDocs) {
- val doc = searcher.doc(hit.doc, setOf("_id"))
- val bytes = doc.getBinaryValue("_id")
+ val doc = searcher.doc(topDocs.scoreDocs.elementAt(0).doc, setOf("_id"))
Review comment:
Looking into it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
