atoulme commented on pull request #351: URL: https://github.com/apache/incubator-tuweni/pull/351#issuecomment-1005893970
I'm not having fun with this PR, the docs build adds 9 minutes. The assemble step runs distribution assembly, which depends on the docs build, which takes 9 minutes. So now we have a massive build for no good reason. The PR fails because we check that we can build from the source distro, and that now runs the docs build, which is slow enough on Windows we time out. There are quite a few ways to go about this, we can make the docs build optional - but then are we testing things? We can cascade the build so docs build first, get cached, then we run assemble with the cached data so we don't do all this work. Or we separate the distro from docs and we ship without docs. That's not a bad option if we publish docs to the website anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tuweni.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tuweni.apache.org For additional commands, e-mail: dev-h...@tuweni.apache.org
