lmccay commented on code in PR #455: URL: https://github.com/apache/incubator-tuweni/pull/455#discussion_r1059658454
########## plumtree-servlet/src/main/java/org/apache/tuweni/plumtree/servlet/GossipServlet.java: ########## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE + * file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file + * to You under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on + * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the + * specific language governing permissions and limitations under the License. + */ +package org.apache.tuweni.plumtree.servlet; + +import org.apache.hc.client5.http.classic.methods.HttpPost; +import org.apache.hc.client5.http.impl.classic.CloseableHttpClient; +import org.apache.hc.client5.http.impl.classic.HttpClients; +import org.apache.hc.core5.http.ContentType; +import org.apache.hc.core5.http.io.entity.ByteArrayEntity; +import org.apache.tuweni.bytes.Bytes; +import org.apache.tuweni.concurrent.AsyncCompletion; +import org.apache.tuweni.concurrent.CompletableAsyncCompletion; +import org.apache.tuweni.plumtree.MessageHashing; +import org.apache.tuweni.plumtree.MessageListener; +import org.apache.tuweni.plumtree.MessageSender; +import org.apache.tuweni.plumtree.MessageValidator; +import org.apache.tuweni.plumtree.Peer; +import org.apache.tuweni.plumtree.PeerPruning; +import org.apache.tuweni.plumtree.PeerRepository; +import org.apache.tuweni.plumtree.State; + +import java.io.IOException; +import java.io.UncheckedIOException; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.concurrent.atomic.AtomicInteger; + +import com.fasterxml.jackson.databind.ObjectMapper; +import jakarta.servlet.ServletConfig; +import jakarta.servlet.ServletException; +import jakarta.servlet.http.HttpServlet; +import jakarta.servlet.http.HttpServletRequest; +import jakarta.servlet.http.HttpServletResponse; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class GossipServlet extends HttpServlet { + + private static final String PLUMTREE_SERVER_HEADER = "Plumtree-Server"; + + private static final Logger logger = LoggerFactory.getLogger(GossipServlet.class); + private static final ObjectMapper mapper = new ObjectMapper(); + + private static final class Message { + + public MessageSender.Verb verb; + public String attributes; + public String hash; + public String payload; + } + + private final int graftDelay; + private final int lazyQueueInterval; + private final MessageHashing messageHashing; + private final String networkInterface; + private final int port; + private final MessageListener payloadListener; + private final MessageValidator payloadValidator; + private final PeerPruning peerPruningFunction; + private final PeerRepository peerRepository; + + private final AtomicBoolean started = new AtomicBoolean(false); + private State state; + + public GossipServlet( + int graftDelay, + int lazyQueueInterval, + MessageHashing messageHashing, + String networkInterface, + int port, + MessageListener payloadListener, + MessageValidator payloadValidator, + PeerPruning peerPruningFunction, + PeerRepository peerRepository) { + this.graftDelay = graftDelay; + this.lazyQueueInterval = lazyQueueInterval; + this.messageHashing = messageHashing; + this.networkInterface = networkInterface; + this.port = port; + this.payloadListener = payloadListener; + this.payloadValidator = payloadValidator == null ? (bytes, peer) -> true : payloadValidator; + this.peerPruningFunction = peerPruningFunction == null ? (peer) -> true : peerPruningFunction; + this.peerRepository = peerRepository; + } + + private CloseableHttpClient httpclient; + + @Override + public void init(ServletConfig config) throws ServletException { + super.init(config); + if (started.compareAndSet(false, true)) { + httpclient = HttpClients.createDefault(); + state = new State(peerRepository, messageHashing, (verb, attributes, peer, hash, payload) -> { + Message message = new Message(); + message.verb = verb; + message.attributes = attributes; + message.hash = hash.toHexString(); + message.payload = payload == null ? null : payload.toHexString(); + HttpPost postMessage = new HttpPost("http://"; + ((ServletPeer) peer).getAddress()); + postMessage.setHeader(PLUMTREE_SERVER_HEADER, this.networkInterface + ":" + this.port); + try { + ByteArrayEntity entity = new ByteArrayEntity(mapper.writeValueAsBytes(message), ContentType.APPLICATION_JSON); + postMessage.setEntity(entity); + httpclient.execute(postMessage, response -> { Review Comment: Again, are we executing a request dispatch here as part of initialization or some expectation that this is called per request? ########## plumtree-servlet/src/main/java/org/apache/tuweni/plumtree/servlet/GossipServlet.java: ########## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE + * file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file + * to You under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on + * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the + * specific language governing permissions and limitations under the License. + */ +package org.apache.tuweni.plumtree.servlet; + +import org.apache.hc.client5.http.classic.methods.HttpPost; +import org.apache.hc.client5.http.impl.classic.CloseableHttpClient; +import org.apache.hc.client5.http.impl.classic.HttpClients; +import org.apache.hc.core5.http.ContentType; +import org.apache.hc.core5.http.io.entity.ByteArrayEntity; +import org.apache.tuweni.bytes.Bytes; +import org.apache.tuweni.concurrent.AsyncCompletion; +import org.apache.tuweni.concurrent.CompletableAsyncCompletion; +import org.apache.tuweni.plumtree.MessageHashing; +import org.apache.tuweni.plumtree.MessageListener; +import org.apache.tuweni.plumtree.MessageSender; +import org.apache.tuweni.plumtree.MessageValidator; +import org.apache.tuweni.plumtree.Peer; +import org.apache.tuweni.plumtree.PeerPruning; +import org.apache.tuweni.plumtree.PeerRepository; +import org.apache.tuweni.plumtree.State; + +import java.io.IOException; +import java.io.UncheckedIOException; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.concurrent.atomic.AtomicInteger; + +import com.fasterxml.jackson.databind.ObjectMapper; +import jakarta.servlet.ServletConfig; +import jakarta.servlet.ServletException; +import jakarta.servlet.http.HttpServlet; +import jakarta.servlet.http.HttpServletRequest; +import jakarta.servlet.http.HttpServletResponse; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class GossipServlet extends HttpServlet { + + private static final String PLUMTREE_SERVER_HEADER = "Plumtree-Server"; + + private static final Logger logger = LoggerFactory.getLogger(GossipServlet.class); + private static final ObjectMapper mapper = new ObjectMapper(); + + private static final class Message { + + public MessageSender.Verb verb; + public String attributes; + public String hash; + public String payload; + } + + private final int graftDelay; + private final int lazyQueueInterval; + private final MessageHashing messageHashing; + private final String networkInterface; + private final int port; + private final MessageListener payloadListener; + private final MessageValidator payloadValidator; + private final PeerPruning peerPruningFunction; + private final PeerRepository peerRepository; + + private final AtomicBoolean started = new AtomicBoolean(false); + private State state; + + public GossipServlet( + int graftDelay, + int lazyQueueInterval, + MessageHashing messageHashing, + String networkInterface, + int port, + MessageListener payloadListener, + MessageValidator payloadValidator, + PeerPruning peerPruningFunction, + PeerRepository peerRepository) { + this.graftDelay = graftDelay; + this.lazyQueueInterval = lazyQueueInterval; + this.messageHashing = messageHashing; + this.networkInterface = networkInterface; + this.port = port; + this.payloadListener = payloadListener; + this.payloadValidator = payloadValidator == null ? (bytes, peer) -> true : payloadValidator; + this.peerPruningFunction = peerPruningFunction == null ? (peer) -> true : peerPruningFunction; + this.peerRepository = peerRepository; + } + + private CloseableHttpClient httpclient; + + @Override + public void init(ServletConfig config) throws ServletException { + super.init(config); + if (started.compareAndSet(false, true)) { + httpclient = HttpClients.createDefault(); + state = new State(peerRepository, messageHashing, (verb, attributes, peer, hash, payload) -> { + Message message = new Message(); + message.verb = verb; + message.attributes = attributes; + message.hash = hash.toHexString(); + message.payload = payload == null ? null : payload.toHexString(); Review Comment: Does this assume that init() is being called per request or something? How would payload not be null? ########## plumtree-servlet/src/main/java/org/apache/tuweni/plumtree/servlet/GossipServlet.java: ########## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE + * file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file + * to You under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on + * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the + * specific language governing permissions and limitations under the License. + */ +package org.apache.tuweni.plumtree.servlet; + +import org.apache.hc.client5.http.classic.methods.HttpPost; +import org.apache.hc.client5.http.impl.classic.CloseableHttpClient; +import org.apache.hc.client5.http.impl.classic.HttpClients; +import org.apache.hc.core5.http.ContentType; +import org.apache.hc.core5.http.io.entity.ByteArrayEntity; +import org.apache.tuweni.bytes.Bytes; +import org.apache.tuweni.concurrent.AsyncCompletion; +import org.apache.tuweni.concurrent.CompletableAsyncCompletion; +import org.apache.tuweni.plumtree.MessageHashing; +import org.apache.tuweni.plumtree.MessageListener; +import org.apache.tuweni.plumtree.MessageSender; +import org.apache.tuweni.plumtree.MessageValidator; +import org.apache.tuweni.plumtree.Peer; +import org.apache.tuweni.plumtree.PeerPruning; +import org.apache.tuweni.plumtree.PeerRepository; +import org.apache.tuweni.plumtree.State; + +import java.io.IOException; +import java.io.UncheckedIOException; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.concurrent.atomic.AtomicInteger; + +import com.fasterxml.jackson.databind.ObjectMapper; +import jakarta.servlet.ServletConfig; +import jakarta.servlet.ServletException; +import jakarta.servlet.http.HttpServlet; +import jakarta.servlet.http.HttpServletRequest; +import jakarta.servlet.http.HttpServletResponse; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class GossipServlet extends HttpServlet { + + private static final String PLUMTREE_SERVER_HEADER = "Plumtree-Server"; + + private static final Logger logger = LoggerFactory.getLogger(GossipServlet.class); + private static final ObjectMapper mapper = new ObjectMapper(); + + private static final class Message { + + public MessageSender.Verb verb; + public String attributes; + public String hash; + public String payload; + } + + private final int graftDelay; + private final int lazyQueueInterval; + private final MessageHashing messageHashing; + private final String networkInterface; + private final int port; + private final MessageListener payloadListener; + private final MessageValidator payloadValidator; + private final PeerPruning peerPruningFunction; + private final PeerRepository peerRepository; + + private final AtomicBoolean started = new AtomicBoolean(false); + private State state; + + public GossipServlet( + int graftDelay, + int lazyQueueInterval, + MessageHashing messageHashing, + String networkInterface, + int port, + MessageListener payloadListener, + MessageValidator payloadValidator, + PeerPruning peerPruningFunction, + PeerRepository peerRepository) { + this.graftDelay = graftDelay; + this.lazyQueueInterval = lazyQueueInterval; + this.messageHashing = messageHashing; + this.networkInterface = networkInterface; + this.port = port; + this.payloadListener = payloadListener; + this.payloadValidator = payloadValidator == null ? (bytes, peer) -> true : payloadValidator; + this.peerPruningFunction = peerPruningFunction == null ? (peer) -> true : peerPruningFunction; + this.peerRepository = peerRepository; + } + + private CloseableHttpClient httpclient; + + @Override + public void init(ServletConfig config) throws ServletException { + super.init(config); + if (started.compareAndSet(false, true)) { + httpclient = HttpClients.createDefault(); + state = new State(peerRepository, messageHashing, (verb, attributes, peer, hash, payload) -> { + Message message = new Message(); + message.verb = verb; + message.attributes = attributes; + message.hash = hash.toHexString(); + message.payload = payload == null ? null : payload.toHexString(); + HttpPost postMessage = new HttpPost("http://"; + ((ServletPeer) peer).getAddress()); + postMessage.setHeader(PLUMTREE_SERVER_HEADER, this.networkInterface + ":" + this.port); Review Comment: I guess this is a means to self seed the peers? How do they discover each other? Would they need to be colocated in the same process? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tuweni.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tuweni.apache.org For additional commands, e-mail: dev-h...@tuweni.apache.org
