Thanks for the RFC. This really is a way forward for TVM CodeGen as i perceive.
:+1:
I have few points to share as below:
P0: I believe we can merge these two as < TAG > + < ID > . Also it would be
good to use numeric rather than target name in ID.
P1: I could not understand clearly the purpose of Keys. If we have Tag &
Targets, why Keys are required? I believe we should have a TAG as master record
to deduce everything in order to identify a particular Target. I think it is
simpler too. :slightly_smiling_face:
P2: If we maintain everything in Attrs as plain Map, we might lose the
intention to achieve hierarchical structure as in case of Composite Targets. So
maybe we want another structure like below:
>
> TargetNodes {
>
> String tag;
>
> Array < TargetNode> targets;
>
> }
Thanks!
---
[Visit Topic](https://discuss.tvm.ai/t/rfc-tvm-target-specification/6844/5) to
respond.
You are receiving this because you enabled mailing list mode.
To unsubscribe from these emails, [click
here](https://discuss.tvm.ai/email/unsubscribe/00d8e2ef58c35089754ffbad32063acf01e717ce1bb0063f772473931752f0d5).
