Github user anwar6953 commented on a diff in the pull request:

    https://github.com/apache/twill/pull/11#discussion_r79760063
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
    @@ -165,7 +165,7 @@ public static ApplicationId createApplicationId(long 
timestamp, int id) {
             tokens = ImmutableList.copyOf(fsTokens);
           }
         } else if (factory instanceof FileContextLocationFactory) {
    -      FileContext fc = ((FileContextLocationFactory) 
locationFactory).getFileContext();
    +      FileContext fc = ((FileContextLocationFactory) 
factory).getFileContext();
    --- End diff --
    
    There's no end-to-end unit test cases in the twill-yarn module. And there's 
no unit tests for this class.
    Any integration test on a secure cluster would've triggered this failure 
though.
    I've verified that the original issue is no longer hit after I made this 
change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to