Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r86287193
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerService.java
---
@@ -123,6 +142,9 @@ protected void doStart() throws Exception {
runnable = Instances.newInstance((Class<TwillRunnable>) runnableClass);
runnable.initialize(context);
+ if (!setLogLevels(Maps.transformValues(logLevels,
Functions.toStringFunction()))) {
+ LOG.error("LoggerFactory is not a logback LoggerContext, cannot
change log level");
--- End diff --
seems that the error logging belongs into the setLogLevels() method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
