Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87242632
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/DefaultResourceReport.java
---
@@ -41,19 +46,15 @@
private final AtomicReference<List<String>> services;
public DefaultResourceReport(String applicationId, TwillRunResources
masterResources) {
- this(applicationId, masterResources, ImmutableMap.<String,
Collection<TwillRunResources>>of());
- }
-
- public DefaultResourceReport(String applicationId, TwillRunResources
masterResources,
- Map<String, Collection<TwillRunResources>>
resources) {
- this(applicationId, masterResources, resources,
ImmutableList.<String>of());
+ this(applicationId, masterResources, Collections.<String,
Collection<TwillRunResources>>emptyMap(),
+ Collections.<String>emptyList());
}
public DefaultResourceReport(String applicationId, TwillRunResources
masterResources,
Map<String, Collection<TwillRunResources>>
resources, List<String> services) {
this.applicationId = applicationId;
this.appMasterResources = masterResources;
- this.usedResources = HashMultimap.create();
+ this.usedResources =
Multimaps.synchronizedSetMultimap(HashMultimap.<String,
TwillRunResources>create());
--- End diff --
Is this change still necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
