Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r91844825
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -384,6 +408,24 @@ private void setEnv(String runnableName, Map<String,
String> env, boolean overwr
}
}
+ private void saveLogLevels(LogEntry.Level level) {
+ level = level == null ? LogEntry.Level.INFO : level;
--- End diff --
Shouldn't default it to `INFO` at all. It should be treated the same as
`null` is provided as the log level value as in the other `saveLogLevels`
method, which will throw `IllegalArgumentException`. Also, rename the `level`
parameter to `rootLogLevel` to be clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
