[ https://issues.apache.org/jira/browse/TWILL-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634237#comment-16634237 ]
ASF GitHub Bot commented on TWILL-262: -------------------------------------- Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/71#discussion_r221663573 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java --- @@ -72,7 +77,23 @@ HADOOP_26 } - private static final Logger LOG = LoggerFactory.getLogger(YarnUtils.class); + private static boolean iDFSUtilClientExists = false; // use this to judge if the hadoop version is above 2.8 --- End diff -- What does the `i` prefix mean? Better just call this `hasDFSUtilClient`. > YarnUtils#cloneHaNnCredentials uses DFSUtil#getHaNnRpcAddresses, which is > removed from DFSUtils from hadoop-2.8 > ---------------------------------------------------------------------------------------------------------------- > > Key: TWILL-262 > URL: https://issues.apache.org/jira/browse/TWILL-262 > Project: Apache Twill > Issue Type: Bug > Components: yarn > Affects Versions: 0.8.0, 0.9.0, 0.11.0, 0.12.0, 0.13.0 > Reporter: Hongyuan Li > Priority: Major > Attachments: errors.txt > > > YarnUtils#cloneHaNnCredentials uses DFSUtil#getHaNnRpcAddresses, which is > removed from DFSUtils from hadoop-2.8 > current code > {code} > public static void cloneHaNnCredentials(Configuration config) throws > IOException { > …… > // Loop through all name services. Each name service could have multiple > name node associated with it. > for (Map.Entry<String, Map<String, InetSocketAddress>> entry : > DFSUtil.getHaNnRpcAddresses(config).entrySet()) { > String nsId = entry.getKey(); > Map<String, InetSocketAddress> addressesInNN = entry.getValue(); > if (!HAUtil.isHAEnabled(config, nsId) || addressesInNN == null || > addressesInNN.isEmpty()) { > continue; > } > …… > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)