----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18043/#review34427 -----------------------------------------------------------
Ship it! Ship It! - Andreas Neumann On Feb. 13, 2014, 12:10 a.m., Terence Yim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18043/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2014, 12:10 a.m.) > > > Review request for Twill. > > > Repository: twill > > > Description > ------- > > Included Throwable information in LogEntry > > 1. API change in LogEntry class > - Add getThrowable() method to return LogThrowable > - Deprecated getStackTraces(). Implementation is to lookup stack trace from > the LogThrowable. > 2. Refactor Gson encode/decode of Log entry related classes to simplify logic. > > > Diffs > ----- > > twill-api/src/main/java/org/apache/twill/api/logging/LogEntry.java 4995328 > twill-api/src/main/java/org/apache/twill/api/logging/LogThrowable.java > PRE-CREATION > twill-api/src/main/java/org/apache/twill/api/logging/PrinterLogHandler.java > 71a2bca > > twill-core/src/main/java/org/apache/twill/internal/AbstractTwillController.java > d45a7c3 > > twill-core/src/main/java/org/apache/twill/internal/json/DefaultLogThrowable.java > PRE-CREATION > > twill-core/src/main/java/org/apache/twill/internal/json/ILoggingEventSerializer.java > PRE-CREATION > > twill-core/src/main/java/org/apache/twill/internal/json/LogEntryDecoder.java > PRE-CREATION > > twill-core/src/main/java/org/apache/twill/internal/json/LogThrowableCodec.java > PRE-CREATION > > twill-core/src/main/java/org/apache/twill/internal/logging/KafkaAppender.java > 8345865 > > twill-core/src/main/java/org/apache/twill/internal/logging/LogEntryDecoder.java > 9bb0896 > twill-yarn/src/test/java/org/apache/twill/yarn/LogHandlerTestRun.java > 30a5a41 > > Diff: https://reviews.apache.org/r/18043/diff/ > > > Testing > ------- > > LogHandlerTestRun test has been modified to include checks for throwable in > log message. > > > Thanks, > > Terence Yim > >
