> On Feb. 13, 2014, 11:32 p.m., Henry Saputra wrote: > > > > Terence Yim wrote: > This only get executed once when AM starts and register itself to RM, not > really in critical performance section. The reason I uses String.format is I > think it's more readable (personally) than using StringBuilder (new > StringBuilder().append(...).append(...).toString()).
I agree with Terence here. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18100/#review34438 ----------------------------------------------------------- On Feb. 13, 2014, 10:54 p.m., Terence Yim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18100/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2014, 10:54 p.m.) > > > Review request for Twill. > > > Repository: twill > > > Description > ------- > > Fix the tracking url registration > > 1. Register the tracking URL without http:// for yarn-2.0.x. > 2. Register without the "/resources" in path. > > > Diffs > ----- > > > twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAMClient.java > e773819 > > twill-yarn/src/main/java/org/apache/twill/internal/appmaster/TrackerService.java > 8ff5184 > > Diff: https://reviews.apache.org/r/18100/diff/ > > > Testing > ------- > > > Thanks, > > Terence Yim > >
