----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19083/#review36972 -----------------------------------------------------------
Ship it! Looks good and straight-forward. - Andreas Neumann On March 12, 2014, 12:13 a.m., Terence Yim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19083/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 12:13 a.m.) > > > Review request for Twill. > > > Repository: twill > > > Description > ------- > > Expose DiscoveryServiceClient through TwillContext to allow > TwillRunnable able to discover services announced within the same > TwillApplication. > > > Diffs > ----- > > twill-api/src/main/java/org/apache/twill/api/TwillContext.java b4ddb6e > twill-core/src/main/java/org/apache/twill/internal/BasicTwillContext.java > 61bdaef > > twill-discovery-api/src/main/java/org/apache/twill/discovery/DiscoveryServiceClient.java > a58c83d > > twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerMain.java > 072bbb0 > twill-yarn/src/test/java/org/apache/twill/yarn/ServiceDiscoveryTest.java > PRE-CREATION > twill-yarn/src/test/java/org/apache/twill/yarn/YarnTestSuite.java bed613a > > Diff: https://reviews.apache.org/r/19083/diff/ > > > Testing > ------- > > New unit test ServiceDiscoveryTest added. All existing test cases passed. > > > Thanks, > > Terence Yim > >
