> On March 12, 2014, 9:36 p.m., Terence Yim wrote: > > twill-ext/src/main/java/org/apache/twill/ext/BundledJarRunner.java, line 53 > > <https://reviews.apache.org/r/19151/diff/2/?file=517694#file517694line53> > > > > Why need to copy before unJar?
I was copying from within the jar, so I thought I needed to copy to the local filesystem first. Anyway, I'm having the bundle jar exist outside of the Twill application jar, so now this is no longer needed. > On March 12, 2014, 9:36 p.m., Terence Yim wrote: > > twill-ext/src/main/java/org/apache/twill/ext/BundledJarRunner.java, line 104 > > <https://reviews.apache.org/r/19151/diff/2/?file=517694#file517694line104> > > > > Why not just always require the file be exists? Isn't that when this > > Runnable is executed with file being localized by Twill? Removed this method. - Jiahua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19151/#review36991 ----------------------------------------------------------- On March 12, 2014, 8:14 p.m., Jiahua Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19151/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 8:14 p.m.) > > > Review request for Twill. > > > Repository: twill > > > Description > ------- > > Implement a TwillApplication that runs bundled jars. This is to allow user > programs to run without having to worry about dependency conflicts with > Twill. For example, Presto uses Guava 16 whereas Twill uses Guava 13, so they > can't run in the same class loader. > > See JarRunnerExample (in twill-examples) for example usage of > BundledJarApplication (in twill-ext). > > > Diffs > ----- > > pom.xml 8e93850 > twill-examples/.gitignore PRE-CREATION > twill-examples/pom.xml PRE-CREATION > twill-examples/src/main/java/org/apache/twill/yarn/HelloWorld.java > PRE-CREATION > twill-examples/src/main/java/org/apache/twill/yarn/JarRunnerExample.java > PRE-CREATION > twill-examples/src/main/resources/org/apache/twill/yarn/bundled.jar.keep > PRE-CREATION > twill-ext/pom.xml PRE-CREATION > twill-ext/src/main/java/org/apache/twill/ext/BundledJarApplication.java > PRE-CREATION > twill-ext/src/main/java/org/apache/twill/ext/BundledJarRunnable.java > PRE-CREATION > twill-ext/src/main/java/org/apache/twill/ext/BundledJarRunner.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/19151/diff/ > > > Testing > ------- > > Tested JarRunnerExample on a single node cluster. Also tested a Twill > application that starts up multiple runnables that run Presto services. > > > Thanks, > > Jiahua Wang > >
