> On March 20, 2014, 7:38 p.m., Terence Yim wrote: > >
In general it looks pretty good already. Just couple more minor comments. - Terence ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19370/#review37957 ----------------------------------------------------------- On March 18, 2014, 8:52 p.m., Jiahua Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19370/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 8:52 p.m.) > > > Review request for Twill. > > > Repository: twill > > > Description > ------- > > BundledJarRunnable is a TwillRunnable that runs bundled jars. > > > Diffs > ----- > > pom.xml 8e93850 > twill-api/src/main/java/org/apache/twill/api/LocalFile.java bcc3e13 > twill-examples/echo/pom.xml PRE-CREATION > twill-examples/echo/src/main/java/echo/EchoMain.java PRE-CREATION > twill-examples/pom.xml PRE-CREATION > twill-examples/yarn/pom.xml PRE-CREATION > > twill-examples/yarn/src/main/java/org/apache/twill/example/yarn/BundledJarExample.java > PRE-CREATION > > twill-examples/yarn/src/main/java/org/apache/twill/example/yarn/HelloWorld.java > PRE-CREATION > twill-ext/pom.xml PRE-CREATION > twill-ext/src/main/java/org/apache/twill/ext/BundledJarRunnable.java > PRE-CREATION > twill-ext/src/main/java/org/apache/twill/ext/BundledJarRunner.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/19370/diff/ > > > Testing > ------- > > BundledJarExample and Presto application. > > > Thanks, > > Jiahua Wang > >
