[
https://issues.apache.org/jira/browse/TWILL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555634#comment-14555634
]
ASF GitHub Bot commented on TWILL-129:
--------------------------------------
GitHub user chtyim opened a pull request:
https://github.com/apache/incubator-twill/pull/34
(TWILL-129) Fix race condition in leader election
- If the node to watch is gone, re-run the leader election
- Use getData() instead of exists() to set the watch
- Avoid “leaking” watches on node that is gone
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/incubator-twill feature/TWILL-129
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-twill/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit eb7b82f723785bf3b941ff86d5ea7f19a495465d
Author: Terence Yim <[email protected]>
Date: 2015-05-22T06:03:36Z
(TWILL-129) Fix race condition in leader election
- If the node to watch is gone, re-run the leader election
- Use getData() instead of exists() to set the watch
- Avoid “leaking” watches on node that is gone
----
> Race condition in leader election if leader quitted before follower set the
> watch
> ---------------------------------------------------------------------------------
>
> Key: TWILL-129
> URL: https://issues.apache.org/jira/browse/TWILL-129
> Project: Apache Twill
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.4.0-incubating, 0.5.0-incubating, 0.4.1-incubating
> Reporter: Terence Yim
> Assignee: Terence Yim
> Priority: Blocker
>
> In the LeaderElection implementation, if the leader quit and delete its node
> before the next-in-line follower try to set the watch through the exists()
> call, the follower will fail silently without noticing the leader node is
> gone.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
