[ 
https://issues.apache.org/jira/browse/TWILL-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584020#comment-14584020
 ] 

ASF GitHub Bot commented on TWILL-24:
-------------------------------------

Github user hsaputra commented on a diff in the pull request:

    https://github.com/apache/incubator-twill/pull/39#discussion_r32352103
  
    --- Diff: twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java 
---
    @@ -186,6 +187,15 @@
       TwillPreparer addSecureStore(SecureStore secureStore);
     
       /**
    +   * Enable log level for Twill applications running in a container.
    +   *
    +   * @param logLevel the {@link LogEntry.Level} that should be enabled.
    +   *                 The level match the {@code Logback} levels.
    +   * @return This {@link TwillPreparer}.
    +   */
    +  TwillPreparer enableLogLevel(LogEntry.Level logLevel);
    --- End diff --
    
    Well, looking again at other "withXXX" methods it usually add something to 
the configuration. I guess this is more similar to "enableDebugging" method 
where you turn on some level of debugging 


> log level should be settable
> ----------------------------
>
>                 Key: TWILL-24
>                 URL: https://issues.apache.org/jira/browse/TWILL-24
>             Project: Apache Twill
>          Issue Type: Improvement
>          Components: api, core
>            Reporter: Albert Shau
>
> Currently the log level is fixed at info, so users have no way of looking at 
> their  log messages at lower levels.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to