Github user chtyim commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/46#discussion_r32978614
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -56,7 +56,8 @@
/**
* Get a snapshot of the resources used by the application, broken down
by each runnable.
*
- * @return A {@link ResourceReport} containing information about
resources used by the application.
+ * @return A {@link ResourceReport} containing information about
resources used by the application or
+ * null in case the user calls this before the application
completely starts.
*/
ResourceReport getResourceReport();
--- End diff --
Mark the method with `@Nullable` as well since it can return null.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
