Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/incubator-twill/pull/49#discussion_r33530451
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/launcher/TwillLauncher.java ---
    @@ -172,6 +174,13 @@ private static URLClassLoader createClassLoader(File 
dir, boolean useClassPath)
             }
           }
     
    +      String appClassPath = 
System.getenv().get(EnvKeys.APPLICATION_CLASSPATHS);
    --- End diff --
    
    I think it's better to do it in the same way as container classpath, which 
is a Jar entry "classpath" in the container.jar file. For the application 
classpath, it can be a "app.classpath" Jar entry in both the appMaster.jar as 
well as the container.jar


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to