Github user hsaputra commented on a diff in the pull request:

    https://github.com/apache/incubator-twill/pull/52#discussion_r34300512
  
    --- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java 
---
    @@ -61,4 +63,22 @@
        */
       @Nullable
       ResourceReport getResourceReport();
    +
    +  /**
    +   * Restart all instances of a particular {@link TwillRunnable} instance.
    +   *
    +   * @param runnable The name of the runnable to restart.
    +   * @return A {@link Future} that will be completed when the restart 
operation has been done. Either successful
    +   *         or fail, the instance of the future will contains the 
information.
    +   */
    +  Future<List<UpdateRunnableStateResult>> 
restartAllRunnableInstances(String runnable);
    --- End diff --
    
    You mean very descriptive? =)
    I could go with restartAllInstances(String runnable) to indicate you 
restart all instances of a runnable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to