[
https://issues.apache.org/jira/browse/TWILL-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622927#comment-14622927
]
ASF GitHub Bot commented on TWILL-116:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/52#discussion_r34398840
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -179,35 +182,41 @@ ResourceReport getResourceReport() {
* Stops and removes the last running container of the given runnable.
*/
void removeLast(String runnableName) {
+ int maxInstanceId = getMaxInstanceId(runnableName);
+ if (maxInstanceId < 0) {
+ LOG.warn("No running container found for {}", runnableName);
+ return;
+ }
+ removeById(runnableName, maxInstanceId);
+ }
+
+ /**
+ * Stop and remove a container for a runnable on an id.
+ */
+ void removeById(String runnableName, int instanceId) {
containerLock.lock();
try {
- int maxInstanceId = getMaxInstanceId(runnableName);
- if (maxInstanceId < 0) {
- LOG.warn("No running container found for {}", runnableName);
- return;
- }
-
- String lastContainerId = null;
- TwillContainerController lastController = null;
+ String containerId = null;
+ TwillContainerController controller = null;
// Find the controller with the maxInstanceId
--- End diff --
in-line comment is no longer accurate.
> Support for restart instances of runnable in an application
> -----------------------------------------------------------
>
> Key: TWILL-116
> URL: https://issues.apache.org/jira/browse/TWILL-116
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Albert Shau
> Assignee: Henry Saputra
> Fix For: 0.6.0-incubating
>
> Attachments: TWILL-116-design-4.pdf, TWILL-116-design-5.pdf,
> TWILL-116-design-6.pdf, TWILL-116-design-7.pdf, TWILL-116-design-final-2.pdf
>
>
> Once an application is running, it would be good to be able to stop, start,
> and restart a specific runnable of the application without affecting other
> runnables.
> For example, I may be running multiple services in a single application, with
> each service as a different runnable. One of my services gets into an invalid
> state. I now want to restart just that runnable and not the other ones that
> are running properly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
