GitHub user hsaputra opened a pull request:
https://github.com/apache/incubator-twill/pull/53
Cleanup on Apache Twill code seeing from previous PR attempt
When doing previous PR I saw some small cleanups opportunity:
1. Remove unnecessary public meodifiers in the interfaces method definition
because they automatically public.
2. All field members declared in an interface are by default public, static
and final so it is redundant to say it again.
3. Remove unused imports.
4. Remove private modifier in enum constructors bc they inherently private.
5. Remove static modifier for inner classes for interface bc they
inherently static.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsaputra/incubator-twill cleanup_branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-twill/pull/53.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #53
----
commit 58d821f219a641453b2e9791b6eac3937cdcf3cd
Author: hsaputra <[email protected]>
Date: 2015-07-14T17:11:55Z
Cleanup on Apache Twill code.
When doing previous PR I saw some small cleanups opportunity:
1. Remove unnecessary public meodifiers in the interfaces method definition
because they automatically public.
2. All field members declared in an interface are by default public, static
and final so it is redundant to say it again.
3. Remove unused imports.
4. Remove private modifier in enum constructors bc they inherently private.
5. Remove static modifier for inner classes for interface bc they
inherently static.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
