Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/63#discussion_r40227034
--- Diff:
twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAppClient.java
---
@@ -70,8 +72,8 @@ public Hadoop20YarnAppClient(Configuration configuration)
{
}
@Override
- public ProcessLauncher<ApplicationId> createLauncher(TwillSpecification
twillSpec,
- @Nullable String
schedulerQueue) throws Exception {
+ public ProcessLauncher<ApplicationMasterInfo>
createLauncher(TwillSpecification twillSpec,
+ @Nullable
String schedulerQueue) throws Exception {
--- End diff --
Small nit on formatting, is that extra tab chars? Wondering why it has
different green shade?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
