[ 
https://issues.apache.org/jira/browse/TWILL-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947776#comment-14947776
 ] 

ASF GitHub Bot commented on TWILL-63:
-------------------------------------

Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/incubator-twill/pull/66#discussion_r41459679
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
    @@ -137,7 +139,7 @@
       YarnTwillPreparer(YarnConfiguration yarnConfig, TwillSpecification 
twillSpec,
                         YarnAppClient yarnAppClient, ZKClient zkClient,
                         LocationFactory locationFactory, String extraOptions, 
LogEntry.Level logLevel,
    -                    YarnTwillControllerFactory controllerFactory) {
    +                    YarnTwillControllerFactory controllerFactory, byte[] 
twillJarContent) {
    --- End diff --
    
    Shouldn't be `byte[]`. Better be a `InputSupplier<? extends InputStream>`.


> Speed up application launch time
> --------------------------------
>
>                 Key: TWILL-63
>                 URL: https://issues.apache.org/jira/browse/TWILL-63
>             Project: Apache Twill
>          Issue Type: Improvement
>          Components: yarn
>    Affects Versions: 0.2.0-incubating
>            Reporter: Terence Yim
>            Assignee: Shankar Selvam
>             Fix For: 0.7.0-incubating
>
>
> Currently when launching an application, two new jars are always created 
> locally, one for AM (appMaster.jar) and one for Container (container.jar) and 
> copied to HDFS before submitting the application. The jar files could 
> potentially be big and if it doesn't changed, it should require copying to 
> HDFS again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to