Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/65#discussion_r41690956
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java
---
@@ -376,8 +379,13 @@ public void run() {
// Call the callback
invokeCallback(messages, offset);
} catch (Throwable t) {
- if (running || !(t instanceof ClosedByInterruptException)) {
- // Only log if it is still running, otherwise, it just the
interrupt caused by the stop.
+ // Only log if it is still running, otherwise, it just the
interrupt caused by the stop.
+ String expMsg = "Unable to fetch messages on {},service shutdown
is in progress.";
--- End diff --
I would prefer to have different error messages for these 2 new cases to
help debug issue when needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
