Taking a look at the svn trunk for uima-as-distr, I see some things that we
might want to change.

The source contains still the 4.1.1 ActiveMq jars etc. These will be included in
the source-release.zip file, even though they're not used in building the binary
distribution.  I think the 4.1.1 stuff should be removed, to make the source and
binary more consistent, and reduce the size of the source-release distr.

There is in the bin assembly a stanza:

    <fileSet>
      <directory>../uima-as-docbooks/target/site</directory>
      <outputDirectory>docs</outputDirectory>
      <excludes><exclude>pdf/*.fo</exclude></excludes>
      <fileMode>644</fileMode>
      <directoryMode>755</directoryMode>       
    </fileSet

The <excludes>... is no longer needed I think.  The place where the docs come
from (.../target/site) is already properly setup, without this excluded file.

The <fileSet>s for getting things from src/main/apache-activemq-5.4.1 don't seem
quite right.

For instance, at one point is says:

    <fileSet>
      <directory>src/main/apache-activemq-5.4.1</directory>
      <outputDirectory>apache-activemq-5.4.1</outputDirectory>
      <includes><include>conf/**</include></includes>
      <excludes><exclude>conf/**/*.*</exclude></excludes>
      <fileMode>755</fileMode>
      <directoryMode>755</directoryMode>       
    </fileSet> 

and later it says:
    <fileSet>
      <directory>src/main/apache-activemq-5.4.1</directory>
      <outputDirectory>apache-activemq-5.4.1</outputDirectory>
      <excludes><exclude>bin/**</exclude></excludes>
      <fileMode>644</fileMode>
      <directoryMode>755</directoryMode>       
    </fileSet> 

which includes everything except the bin/** - so it includes all of the conf/
above plus the part the above tried to exclude?

-Marshall





Reply via email to