I worked with a strict formatting style for some years now, so it's
really ingrained.
I agree of course with your agruments and will take care that this won't
happen again.
Peter
Am 03.11.2011 17:35, schrieb Jörn Kottmann:
On 11/3/11 5:22 PM, Peter Klügl wrote:
Ok, I deactivate the (format) save action. I was looking for a
different source of this problem.
Can you roll back the class? I would then add my changes again
without formatting.
However, I thought that the source code formatting guide lines should
prevent such stuff, giving a convention for all developers and
support a unified format of the source code. Some text passages of
the Cas Editor classes didn't follow that convention, isn't it then
better to reformat them?
How do you use format? Only for a selection of a file?
If the source code formatting is really off I think it is better to
reformat,
smaller violations or things which even comply to our guide lines should
not be changed, e.g. it limits the maximum line length, when I choose to
break a comment, or source code line before this limit it should not be
reformatted to the maximum allowed line length.
Trailing white spaces also do not reduce the readability of the code
and should
in my opinion not be removed.
Anyway when reformatting is done it should never be mixed with code
changes,
because these code changes are then cumbersome to review.
Jörn
--
---------------------------------------------------------------------
Dipl.-Inf. Peter Klügl
Universität Würzburg Tel.: +49-(0)931-31-86741
Am Hubland Fax.: +49-(0)931-31-86732
97074 Würzburg mail: [email protected]
http://www.is.informatik.uni-wuerzburg.de/en/staff/kluegl_peter/
---------------------------------------------------------------------
