[
https://issues.apache.org/jira/browse/UIMA-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643248#comment-13643248
]
Richard Eckart de Castilho commented on UIMA-2802:
--------------------------------------------------
Decided not to change the signature for sake of an easy upgrade.
Decided not to remove the methods that take a CAS as argument, because seeking
should in fact work even if the coveringAnnotation is not part of the CAS.
Seeking happens via the indexed attributes, not via object equality.
Added more convenience methods without the CAS argument.
Using getView() instead of getCas() in the methods without CAS argument.
> Change selectCovered(class, annotation) signature
> -------------------------------------------------
>
> Key: UIMA-2802
> URL: https://issues.apache.org/jira/browse/UIMA-2802
> Project: UIMA
> Issue Type: Bug
> Components: uimaFIT
> Reporter: Richard Eckart de Castilho
> Assignee: Richard Eckart de Castilho
> Fix For: 2.0.0uimaFIT
>
>
> Change the signature from
> {noformat}
> selectCovered(Class<T> type, AnnotationFS coveringAnnotation)
> {noformat}
> to
> {noformat}
> selectCovered(AnnotationFS coveringAnnotation, Class<T> type)
> {noformat}
> Per convention, the thing to select from should be the first argument(s) and
> the following arguments should specify what to select.
> Probably also change
> {noformat}
> selectCovered(JCas jCas, final Class<T> type, AnnotationFS coveringAnnotation)
> {noformat}
> to
> {noformat}
> selectCovered(JCas jCas, AnnotationFS coveringAnnotation, final Class<T> type)
> {noformat}
> and so on. Probably best to even deprecate/remove the signature with both,
> JCas and coveringAnnotation, because seeking only works when the
> coveringAnnotation is part of the CAS.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
