[
https://issues.apache.org/jira/browse/UIMA-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804334#comment-13804334
]
Jens Grivolla commented on UIMA-2387:
-------------------------------------
Btw, the whole patch consists in checking if the "ResultingAnnotationName" is
defined and otherwise skipping the creation of a new annotation. That's why it
just moves large chunks of code into an "if" block.
At least for makeAnnotation() I could make the diff much smaller by putting "if
(resultAnnotationType == null) return;" at the beginning instead of moving the
whole method into a block. I don't know if that would be the preferred style
(it would be more easily visible that the whole method gets skipped).
> ResultingAnnotationName not optional in ConceptMapper
> -----------------------------------------------------
>
> Key: UIMA-2387
> URL: https://issues.apache.org/jira/browse/UIMA-2387
> Project: UIMA
> Issue Type: Bug
> Components: addons, Sandbox-ConceptMapper
> Affects Versions: 2.3.1Addons
> Reporter: Jens Grivolla
> Priority: Minor
> Attachments: UIMA-2387.patch
>
>
> Contrary to the documentation, the ResultingAnnotationName is not optional in
> the ConceptMapper descriptor. In our use case we only want to write back
> information to the original token, without creating a new annotation. Instead
> of treating this as a documentation bug it is therefore better to fix the
> code.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
