[ 
https://issues.apache.org/jira/browse/UIMA-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877495#comment-13877495
 ] 

Marshall Schor commented on UIMA-3567:
--------------------------------------

The first problem is due to imprecise English in the instructions.  The intent 
was to cd to the root directory of the source distribution (as it said), and 
then, to run the script - but it didn't say how.  Because the script is (as you 
discovered) not at the root directory of the source distribution, you would 
need to run it by doing src\main\readme_src\addSourceToJars.bat.  This would 
make the paths in the bat file correct :-)

The 2nd problem: thanks for reporting this.  In other scripts, we've fixed this 
by putting quotes in slightly different places, which don't result in the extra 
quotes in the value.  We do:
{{if "%JAVA_HOME%"=="" (set UIMA_JAVA_CALL=java) else (set 
"UIMA_JAVA_CALL=%JAVA_HOME%\bin\java").  I'll make this kind of change 
(substituting JAR for JAVA where appropriate).  Then the 3rd issue should not 
be present.

To fix the first problem, I'll update the documentation.  That needs updating, 
anyways, because if you install the m2e plugin for recent versions of Eclipse, 
you won't need to do anything to get the source - Eclipse will magically just 
find it from Maven central.

> addSourceToJars.bat has numerous errors
> ---------------------------------------
>
>                 Key: UIMA-3567
>                 URL: https://issues.apache.org/jira/browse/UIMA-3567
>             Project: UIMA
>          Issue Type: Bug
>          Components: Build, Packaging and Test
>    Affects Versions: 2.5.0SDK
>         Environment: Windows 7, Java 7.
>            Reporter: John M. Boyer
>            Priority: Minor
>              Labels: easyfix
>
> There are three error types in addSourceToJars.bat and one error in the 
> documentation overview_and_setup.pdf section 3.3.
> The doc says to go to the root directory of the source distribution to run 
> addSourceToJars.  However, this batch file is no longer at the root 
> directory. It is now under the following additional subdirectories: src main 
> readme_src
> As a result, first error is that the line 
> cd jVinci\src\main\java
> should be changed to
> cd ..\..\..\jVinci\src\main\java
> The second problem is that a typical installation of Java is installed to 
> Program Files, which contains spaces.  Therefore, the following line causes 
> unexpected symbols that result in unsuccessful termination of the batch file.
> if "%JAVA_HOME%"=="" (set UIMA_JAR_CALL=jar) else (set 
> UIMA_JAR_CALL=%JAVA_HOME%\bin\jar)
> To fix, it is necessary to surround the second occurrence of %JAVA_HOME% in 
> quotes, like this:
> if "%JAVA_HOME%"=="" (set UIMA_JAR_CALL=jar) else (set 
> UIMA_JAR_CALL="%JAVA_HOME%"\bin\jar)
> However, the quotes seem to carry over into the use of UIMA_JAR_CALL, so it 
> becomes necessary to fix the 8 occurrences of 
> "%UIMA_JAR_CALL%"
> to remove the surrounding quotes, like this
> %UIMA_JAR_CALL%



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to