[ 
https://issues.apache.org/jira/browse/UIMA-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490323#comment-14490323
 ] 

Marshall Schor commented on UIMA-4343:
--------------------------------------

I've checked in my version; it puts all the FSs into a list and then sorts 
them, using the same comparison code.  This is similar to the cas-obj approach 
- putting all the FSs into a HashSet, where the key is a wrapped FS, and the 
wrapper defines an equal / hashcode.  One difference is that if the copy 1 has 
5 instances of some FS, and copy 2 has more (e.g. 6), this will be caught by 
the sorting approach, but missed by the set approach, I think.

> Testing uses cas compare function, make this order independent
> --------------------------------------------------------------
>
>                 Key: UIMA-4343
>                 URL: https://issues.apache.org/jira/browse/UIMA-4343
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Core Java Framework
>    Affects Versions: 2.7.0SDK
>            Reporter: Marshall Schor
>            Assignee: Marshall Schor
>            Priority: Minor
>             Fix For: 2.7.1SDK
>
>
> Some tests compare two CASes for (approximate) equality, but the compare 
> requires the items in the CASes be in the same "order".  Newer iterator 
> implementations of bag and sets no longer necessarily preserve ordering, so 
> the compare may fail even though the CASes contain the same 
> FeatureStructures.  Improve the CAS compare test to permit comparing equal 
> without needing the same ordering.
> Remove extra test class CasComparerViewChange, have its 2 users directly call 
> the compare function.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to