Hi, first of all: thanks for reviewing :-)
comments below... Am 10.05.2015 um 22:19 schrieb Richard Eckart de Castilho: > Some intermediate results and questions: > > Build from sources using clean repo and Oracle Java 1.8.0_45-b14 (without > apache-release) - OK > > Build from sources using clean repo and Oracle Java 1.8.0_45-b14 (with > apache-release) - JavaDoc does not build (not critical) I used Java 7 for the release. I will try to reproduce it with Java 8 > German month in docs - not critial > > Example breaking out page boundary (PDF page 61) - not critical I will take care of it. > Some examples contain a NOTICE/LICENSE file, others not - why? This could be a problem. Before this rc, only UIMA Ruta projects (which are not built with maven) contained these files. We had some discussion some time ago that these project do not contain these files. I don't know if it is really necessary (since they are only accessed as source and build no artifacts) but it didn't hurt to add them. The only maven project project ruta-ep-example-extensions specifies ruta-parent as parent und thus should copy these files when built. Now there are some more projects that do not contain these files: ruta-maven-example is a maven project, but specifies no parent at all (files won't be copied). ruta-tutorial-GermanNovels is a some sort of LaTeX project. No artifacts will be distributed for both project so I hope that this could maybe not be a blocker? > Questions - Should the "TM" be for "Apache UIMA" or "Apache UIMA Ruta"? Good question. I also thought about it and we should probably start to use it for Ruta. Did you notice any legal concerns when you introduced it for uimaFIT? Should it be Apache UIMA (TM) Ruta (TM), which looks a bit strange, or could we use Apache UIMA Ruta (TM)? > The Spring JARs contain some sections in their LICENSE files not replicated > in the LICENSE of the distribution / ruta engine JAR. These sections might > not apply, but I wonder if anybody really checked if they do not apply. The > Spring guys might just have copied stuff e.g. from ASM into Spring and > spring-asm is in fact part of the ruta engine JAR. Sorry if this might have > been discussed/observed before. Hmm, yes, there was a discussion, but I do not remember the details right now. We had some iterations and, afterwards, I was quite confident that the license file is correct. Maybe I even removed the mention again after the discussion. The dependency first came with uimaFIT. How did you handle it in the license file? > README file is still mentioning "uimaFIT JCasGenPomFriendly" - should be > upgraded to the Apache UIMA jcasgen-maven-plugin. Some people could still use the old variant, but I asume that the problem (double classes) could also occur with the maven plugin, right? Best, Peter > Cheers, > > -- Richard > > On 30.04.2015, at 13:04, Peter Klügl <[email protected]> wrote: > >> Hi, >> >> the first release candidate of Apache UIMA Ruta v2.3.0 is ready for voting. >> >> Summary of changes: >> >> UIMA Ruta Language and Analysis Engine: >> - Requires Java 7 >> - Maven Plugin for UIMA Ruta >> - Extensions and simplifications of the language (external resources, null >> values, more syntactic sugar) >> - Improvements to Analysis Engines (RutaEngine, HtmlConverter) >> - More exemplary script projects >> - Many, many bug fixes >> >> UIMA Ruta Workbench: >> - Requires Java 7 >> - Works now also in other project structures (Maven projects) >> - Bug fixes >> >> This release requires an update of script projects and its descriptors, >> e.g, in the UIMA Ruta Workbench by deleting all descriptors and updating the >> script project. >> Right-click on a project and select "UIMA Ruta -> Convert to UIMA Ruta >> project" >> >> Staging repository: >> https://repository.apache.org/content/repositories/orgapacheuima-1050/ >> >> SVN tag: >> https://svn.apache.org/repos/asf/uima/ruta/tags/ruta-2.3.0 >> >> Update site: >> http://people.apache.org/~pkluegl/uima-releases/ruta-2.3.0-rc1/eclipse-update-site/ruta >> >> Archive with all sources: >> http://people.apache.org/~pkluegl/uima-releases/ruta-2.3.0-rc1/ruta-2.3.0-source-release.zip >> >> Overall 67 issues have been fixed for this release. >> They can be found in the RELEASE_NOTES.html. >> >> ... and here: >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20UIMA%20AND%20fixVersion%20%3D%202.3.0ruta%20AND%20component%20%3D%20ruta%20ORDER%20BY%20created%20DESC >> >> Please vote on release: >> >> [ ] +1 OK to release >> [ ] 0 Don't care >> [ ] -1 Not OK to release, because ... >> >> Thanks. >> >> Peter >>
