[ 
https://issues.apache.org/jira/browse/UIMA-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698646#comment-14698646
 ] 

Peter Klügl commented on UIMA-4556:
-----------------------------------

Hi,

first of all: thanks :-)

a few small things:

I plan to prepare a release candidate for 2.3.1 soon. In order to be included 
in the issue report, the issue needs to specify the fixVersion. You can also 
assign yourself to the issue.

The getter for the boolean value misses the match context. This is hardly ever 
useful for this action, but I had already problems with some rules because I 
did not set it in other langauge elements. It is used to allow feature matches 
as agruments for the action, like MARKTABLE(..., SomeAnnotation.booleanFeature, 
...)

It would not break compatibility if we make the argument optional:

{code}
MARKTABLE(TypeExpression, NumberExpression, TableExpression 
          (,BooleanExpression, NumberExpression, 
          StringExpression, NumberExpression, BooleanExpression?)? 
          (,StringExpression = NumberExpression)+)
{code}

What are the use cases if the user cannot configure it using the language?


> MARKTABLE does not support ignoring whitespaces in the entries of the 
> dictionary
> --------------------------------------------------------------------------------
>
>                 Key: UIMA-4556
>                 URL: https://issues.apache.org/jira/browse/UIMA-4556
>             Project: UIMA
>          Issue Type: Bug
>          Components: ruta
>    Affects Versions: 2.3.1ruta
>            Reporter: Renaud Richardet
>            Priority: Minor
>             Fix For: 2.3.1ruta
>
>
> MARKFAST's last parameter allows to specify whether whitespaces in the 
> entries of the dictionary should be ignored. [see 
> docs|https://uima.apache.org/d/ruta-current/tools.ruta.book.html#ugr.tools.ruta.language.actions.markfast]
> MARKTABLE does not support this. One way to add this feature is to support it 
> down to the scripting language. However, it would break backwards 
> compatibility, since it would change the syntax from
> {code}
> MARKTABLE(TypeExpression, NumberExpression, TableExpression 
>           (,BooleanExpression, NumberExpression, 
>           StringExpression, NumberExpression)? 
>           (,StringExpression = NumberExpression)+)
> {code}
> to
> {code}
> MARKTABLE(TypeExpression, NumberExpression, TableExpression 
>           (,BooleanExpression, NumberExpression, 
>           StringExpression, NumberExpression, BooleanExpression)? 
>           (,StringExpression = NumberExpression)+)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to