[
https://issues.apache.org/jira/browse/UIMA-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698952#comment-14698952
]
James Zhu edited comment on UIMA-4554 at 8/17/15 3:05 AM:
----------------------------------------------------------
Hi, Marshall:
Now that I know the history of it, it makes sense to me that when we were using
the UIMA 2.3.0 incubator release we didn't have such problems. Only after we
upgraded to UIMA 2.4.0 and later, we started seeing tons of unnecessary
@SuppressWarnings("hiding") in the JCasGen generated code and we had to tweak
our Eclipse settings to make them go away.
This is all because you were asked to add the @SuppressWarnings("hiding") per
UIMA-1983.
The thing is, I never experienced the problem reported by UIMA-1983. On the
contrary, the change for UIMA-1983 started causing the compiler warnings in
Eclipse IDE and we had to work around it by changing Eclipse settings.
You suggest we still keep the @SuppressWarning("hiding") in. With Eclispe's
default settings, such lines are not necessary. So it is weird that we have to
include such lines in the JCasGen generated code and then turn around and
change Eclipse settings to ignore them. Is it because it helps other people who
are not using Eclipse IDE? I am a little confused now.
James
was (Author: jichun):
Hi, Marshall:
Now that I know the history of it, it makes sense to me that when we were using
the UIMA 2.3.0 incubator release we didn't have such problems. Only after we
upgraded to UIMA 2.4.0 and later, we started seeing tons of unnecessary
@SuppressWarnings("hiding") in the JCasGen generated code and we had to tweak
our Eclipse settings to make them go away.
This is all because you were asked to add the @SuppressWarnings("hiding") per
UIMA-1983.
The thing is, I never experienced the problem reported by UIMA-1983. On the
contrary, the change for UIMA-1983 started causing the compiler warnings in
Eclipse IDE and we had to work around it by changing Eclipse settings.
You suggest we still keep the @SuppressWarning("hiding") in. Is it because it
helps other people who are not using Eclipse IDE? I am a little confused now.
James
> JCasGen generating rawType warnings for fsGenerator
> ---------------------------------------------------
>
> Key: UIMA-4554
> URL: https://issues.apache.org/jira/browse/UIMA-4554
> Project: UIMA
> Issue Type: Bug
> Components: Tools
> Affects Versions: 2.8.1SDK
> Reporter: Marshall Schor
> Priority: Minor
> Fix For: 2.8.2SDK
>
> Attachments: UIMA-4554 patch 2015-08-15 - uimaj-jet-expander.patch,
> UIMA-4554 patch 2015-08-15.patch, uimaj-tools-UIMA-4554-2015-08-11.patch
>
>
> JCasGen generate references to FsGenerator which was changed in 2.8.0 to have
> generic type information. So the resulting generated code causes warnings
> about raw types being used. Workaround - add a
> @SuppressWarnings("rawtypes"), but a better thing would be to add the proper
> generic arguments.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
