[
https://issues.apache.org/jira/browse/UIMA-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070349#comment-15070349
]
Richard Eckart de Castilho commented on UIMA-4212:
--------------------------------------------------
I've had a look at the patch (finally!)
* You don't have any unit tests for the new method by any chance, do you?
* I am pretty sure the type subsumption test in the offsets-based
selectIntersects is not needed
* given that the annotation index is sorted, it should be possible to stop
iteration early in the offsets-based method like in the
reference-annotation-based method
* I'd tend to rename the methods to "selectIntersecting" (cf. "selectCovering")
> Add methods to CasUtil to select and index intersecting annotations
> -------------------------------------------------------------------
>
> Key: UIMA-4212
> URL: https://issues.apache.org/jira/browse/UIMA-4212
> Project: UIMA
> Issue Type: Improvement
> Components: uimaFIT
> Reporter: Jose Tomas Atria
> Assignee: Richard Eckart de Castilho
> Priority: Minor
> Labels: newbie, patch
> Fix For: 2.2.0uimaFIT
>
> Attachments: selectIntersects.patch
>
>
> CasUtil includes methods to select and index covered and covering annotations
> of a given type (ie, supersets and subsets of an annotation's interval).
> The attached patch adds methods to select and index intersecting annotations,
> either including covering annotations or not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
