I've scheduled a build...
On 7/18/2016 9:39 AM, Marshall Schor wrote: > I'm trying this - I just committed a change to make the examples code > identical > to the version in core. > > Let's see if this makes JaCoCo happier. > > -Marshall > > On 7/18/2016 9:21 AM, Marshall Schor wrote: >> The classes complained about are the two classes for SourceDocumentInfo (and >> SourceDocumentInfo_Type). These are identical except the one in the >> uimaj-core >> has more comments in the Javadocs. >> >> The complaint in the error message I see is that the duplicate class is not >> identical - so maybe a trivial fix is to make them identical? (Copy the >> version >> in uimaj-core with the enhanced javadoc comments to the examples). >> >> If that would work that would certainly be the least disruptive to our users >> :-). Can you try that? >> >> -Marshall >> >> On 7/18/2016 2:41 AM, Richard Eckart de Castilho wrote: >>> While putting a final touch on this, JaCoCo (a code-coverage tool >>> alternative >>> to Cobertura) pointed out another problem: >>> >>> The JCas wrappers for the "example type" SourceDocumentInformation is >>> present >>> in uimaj-core and also in uimaj-examples. JaCoCo doesn't like this. >>> >>> I don't quite understand why we ship an example class with uimaj-core. >>> >>> However, I believe that some people have started relying on it, so we >>> probably should not remove it from uimaj-core (yet), right? >>> >>> How about removing it from uimaj-examples then? >>> >>> Best, >>> >>> -- Richard >>> >>>> On 15.07.2016, at 20:26, Marshall Schor <[email protected]> wrote: >>>> >>>> I was reading the Jira issue looking for the commits in the old spot and >>>> not >>>> seeing any, and came to the wrong conclusion that no work had yet been >>>> done. I >>>> see there's been a fair amount of work already done - the commits link was >>>> moved >>>> in Jira to the upper right part of the screen... >>>> >>>> Can I mark this issue as resolved to included it in 2.8.2? >>>> >>>> I know we eventually want to move this to the uima-wide build pom, but >>>> that can >>>> be done whenever... >>>> >>>> -Marshall >>>> >>>> >>>> On 7/15/2016 11:38 AM, Marshall Schor wrote: >>>>> I want to collect (most of) the ready-to-go fixes, especially including >>>>> the ones >>>>> to permit running with Eclipse 4.6 (Neon), and do the next uimaj-release. >>>>> >>>>> >>>>> There an issue UIMA-4580 (assigned to Richard) saying Java 8 isn't >>>>> working with >>>>> some of the QA tooling in the Jenkins builds. It's currently said to be >>>>> fixed >>>>> in the next uimaj-release - will this happen soon, or can we defer to a >>>>> subsequent release? >>>>> >>>>> -Cheers! -Marshall >>>>> >>>>> >
