Thanks for the good feedback Burn, and apologies the migration was painful! Let's learn from the pain... I'll put in some Jira's for improvement, as I gain sufficient understanding to do this :-)
-Marshall On 11/9/2017 11:32 AM, Burn Lewis wrote: > - checked signatures on binary > - built from source and checked signatures > - ran a couple UIMA pipelines on both builds > - migrated a pipeline with many types and ran it on both builds > - spot-checked readme etc. > > [X] +1 OK to release > > Minor complaints: > - JCasImpl has a getType method that throws "UIMA V2 operation not > supported in V3" ... perhaps it should refer to a section in the docs about > changes to internal classes and suggested alternatives. > > - migration of a large set of projects is painful - > When sourcesRoots contains multiple projects the converted classes are put > in the same folder making it difficult to copy them to the appropriate > project. Perhaps an in-place option could be supported which could be used > after verifying that an earlier migration has succeeded, or by relying on > a source control system to undo any unwanted changes. This option could > also delete the obsolete xxx_Type classes. > Also the migrated source should include a comment recording the migration, > and should retain comments such as. copyright headers. > Would it help to suggest re-running jcasgen instead of converting the jcas > classes? > > Burn > > > > > On Tue, Nov 7, 2017 at 12:25 PM, Jaroslaw Cwiklik <[email protected]> > wrote: > >> working on it now ... will vote this afternoon >> >> -Jerry >> >> On Tue, Nov 7, 2017 at 8:42 AM, Marshall Schor <[email protected]> wrote: >> >>> gentle reminder ... one more vote needed ... -Marshall >>> >>> >>> On 11/2/2017 10:15 AM, Marshall Schor wrote: >>>> Hi everyone, >>>> >>>> Here's rc8 for uimaj 3.0.0-beta. >>>> >>>> The changes since rc7 include some xml constants fixups to not depend >> on >>> java >>>> classes that may not be present in various versions of Java. >>>> >>>> Also included are general improvements in adding generic typing to many >>> UIMA >>>> structures, updates to add missing javadocs, missing APIs in the jcas >>> interface >>>> for getting "empty" lists, and some upgrades to the main documentation >>> and >>>> examples to better reflect v3 idioms. >>>> >>>> The updates to generic typing are designed to not break existing code, >>> and it >>>> seems to be OK as far as I was able to test; it would be great if you >>> could test >>>> this against other big projects (like dk-pro) to see if anything got >>> missed. >>>> Here are the Jiras: >>>> >>>> https://issues.apache.org/jira/issues/?jql=project%20% >>> 3D%2012310570%20AND%20fixVersion%20%3D%2012339590% >>> 20ORDER%20BY%20key%20DESC%2C%20priority%20DESC >>>> Maven artifacts: >>>> https://repository.apache.org/content/repositories/orgapacheuima-1165/ >>>> >>>> Source and binary zip/tar staged to: >>>> https://dist.apache.org/repos/dist/dev/uima/uimaj/3.0.0- >>> beta-rc8/artifacts/ >>>> Eclipse update subsite: >>>> https://dist.apache.org/repos/dist/dev/uima/uimaj/3.0.0- >>> beta-rc8/uimaj-v3-pre-production/ >>>> SVN tag: https://svn.apache.org/repos/asf/uima/uv3/uimaj-v3/tags/ >>> uimaj-3.0.0-beta/ >>>> Please vote on release: >>>> >>>> [ ] +1 OK to release >>>> [ ] 0 Don't care >>>> [ ] -1 Not OK to release, because ... >>>> >>>> Thanks. >>>> >>>> -Marshall >>>> >>>> >>>
