re: Jenkins being able to monitor and build on pushes to branch name patters:
good to know! 

Thanks for leading the way :-) -Marshall

On 11/26/2018 4:24 PM, Richard Eckart de Castilho wrote:
> On 26. Nov 2018, at 22:14, Marshall Schor <[email protected]> wrote:
>> Thanks.  For each PR branch, do you need to set up a specific Jenkins
>> configuration / job to build that branch? 
> One Jenkins job per repo can monitor all PRs on that repo. It just requires
> some special setup, namely that it be triggered when somebody pushes to the
> GitHub repo (filtered by a specific branch name pattern) and that it picks 
> up the commit hash to trigger the proper build. 
>
>> (I'm not sure exactly what a "PR branch" would be.  Suppose I open a Jira for
>> something that might be of small-medium size, and did a branch for that.  
>> Would
>> that be a "PR branch" ?)
> A PR branch would be any branch underlying a PR - in contrast to e.g. the 
> "master"
> branch or "maintenance" branches such as "2.4.x". Not sure if I am using 
> "official"
> terminology here. 
>
> For the projects that I am maintaining, I ask people to open PRs as soon as 
> they
> have started working on something and have made the first commit. That makes 
> it
> easier to see who's working on what and allows code reviews and comments even
> as the work is ongoing. Others might prefer opening a PR only once they are 
> done
> with their changes.
>
> Cheers,
>
> -- Richard

Reply via email to