re: closing a pull request after committing the change to SVN. The github help gives instructions on how to do this that are ineffective, because they say to click the "close" button below the comment box at the bottom, but there is no such button.
I'm guessing this is because I don't have permission to close the pull request, although it seems like the creator of the pull request could. Does this seem right, or am I missing something? -Marshall On 12/20/2018 2:19 PM, Richard Eckart de Castilho wrote: > On 20. Dec 2018, at 17:18, Marshall Schor <[email protected]> wrote: >> I'm looking for a little hand-holding re: using the apache mirrored github. >> >> I can see there some pull requests for uimaj. I can open them and observe >> the diff. >> >> Because these are just "mirrors", I think I can't do anything except to >> manually >> copy these changes into an SVN set-up source, and then commit that. Is that >> correct? > Well, you should be able to review and discuss the changes - make comments if > necessary > and ask for changes. > > But once the patch is ready, you'd have to download it and manually apply it > to the SVN, yes. > >> If I do that, is there something I do on the github mirror to indicate I've >> "accepted" and "applied " the change? > You can leave a comment saying that it has been merged. The PR should contain > a link to the > corresponding Jira. It would also be possible to define a custom label like > "Merged" to mark > such PRs. But other than that, the only option is afaik to just close them > once they are done. > > -- Richard > >
