Thanks for reviewing :-)
Am 22.02.2019 um 13:35 schrieb Richard Eckart de Castilho:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Checked signature and hash on sources artifact: OK
Spot checked diff between RC2 and RC3: OK (with comments)
There are various whitespace-only changes which make files to
appear having changes which do not or having more changes than
required. Might consider adding checkstyle and auto-save actions
in Eclipse e.g. to remove trailing whitespace and to ensure
consistent use of spaces vs. tabs.
I have to check that, but I would guess that the changes were maybe made
by checkstyle and autosave.
Building locally from source ZIP with Java 11: FAILS (not a blocker)
Getting these when trying when maven-invoker-plugin:2.0.0:run
(integration-test) @ ruta-maven-plugin is run (see log files of
the individual integration test runs).
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] Source option 5 is no longer supported. Use 6 or later.
[ERROR] Target option 1.5 is no longer supported. Use 1.6 or later.
[INFO] 2 errors
I would suggest to set up a Jenkins Build Job for Ruta using Java 11.
Yes, I will create a Jenkins Job. I wonder why the project built
succesfully with ##java 11 on my machine...
Best,
Peter
Building locally from source ZIP with Java 8: OK
Installing into Eclipse: OK (with comments)
Still cannot install only via
https://dist.apache.org/repos/dist/dev/uima/ruta-2.7.0-rc3/eclipse-update-site/ruta/
but have to install UIMA plugins first from
https://www.apache.org/dist/uima/eclipse-update-site/:
Software being installed: UIMA Ruta Workbench 2.7.0
(org.apache.uima.ruta.feature.feature.group 2.7.0)
Missing requirement: UIMA Ruta Workbench 2.7.0
(org.apache.uima.ruta.feature.feature.group 2.7.0) requires
'org.eclipse.equinox.p2.iu; org.apache.uima.tools.feature.group 2.9.0' but it
could not be found
Imported example projects into Eclipse: OK
Sorry for the long time it took to get the review done.
[+1] to release
- -- Richard
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEEPY2MKJLmMo4NDQCrO8wPPFbjAA4FAlxv7JBfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNE
OEQ4QzI4OTJFNjMyOEUwRDBEMDBBQjNCQ0MwRjNDNTZFMzAwMEUACgkQO8wPPFbj
AA6iag/+MC2RGZBokTTTve/Gjgo3uZGUhPveBz5oTAWz+n0mV930Wo1tsXEK803P
o99CrB37BT001iscHIE7ytjTNOQy2F9GmMFu+eKfCdMdKFqO2fu4DpyUl9KX81uy
Y8MWx3WNjQPvnoE0Ij2dfNJDDgHuayP0nNrtByJiMUmWDqYh6bFMFzsEM2FRyD5y
2eCNanVwjzHdbSOruusIjfoXJIuOkxwRkwleS+MYSxcQVuh/kaY+fLAdf+2lJu1H
Z+ku8y7FGMH+xTglkUVJTm4twCW+BZcLTc8ISYTdDrvtmoKhfMNPwLBfancCVTOT
k5/7R9V5IMx5scRVMIJotCSd01xuIckSoejnq5sYjXddrrtIXDlRSjNqu6uSYyLV
M7GI5r8eHFrJIeIdoZXWMtewVIt/uH22b0r5Ccy+FdyR6Hfr0rxhT7HGJgxxq9QM
t+xJkbx9pupXWSwoijcWuPCZ0SXuHFJfkPQxvaoB6dd0uu+eNSgE8BufJkdGDlwe
7A7+hh/6voAMNzRqN48Z54oyaezLL829OnhKiqKzh19ItXlaeBf7h2vdee0btz2J
XAU9ipFS7Owon79ZVprTNTFH34xjntZzvteZmH8D5HN8lD7BahRmgejhtuNJZ4/E
nRuzXNDjqvJrD2JuuS7m6plbMxnNI1OUb24zpeEwDhEGIloNRyo=
=OyY5
-----END PGP SIGNATURE-----
--
Peter Klügl
R&D Text Mining/Machine Learning
Averbis GmbH
Tennenbacher Str. 11
79106 Freiburg
Germany
Fon: +49 761 708 394 0
Fax: +49 761 708 394 10
Email: [email protected]
Web: https://averbis.com
Headquarters: Freiburg im Breisgau
Register Court: Amtsgericht Freiburg im Breisgau, HRB 701080
Managing Directors: Dr. med. Philipp Daumke, Dr. Kornél Markó
