On 1. Apr 2019, at 14:57, Marshall Schor <[email protected]> wrote: > > :-) Thanks for the quick response! -M
Well, your mail came when I was just about to review 3.1.0 :) So while I'm at it, here are some comments I had already noted down (non-blockers): - CasCompare is in src/main/java but seems to contain quite a bit of debugging code / debugging messages that go directly to System.out. If it is a test utility, then it would probably be good to move it to the `uimaj-test-util` module so it can be used for testing across different core modules. If it is meant to be reusable, then it should make proper use of SLF4J to logging. - I don't understand the this in "uv3.select.xml": ... _id()) with the bounding Annotation, it is always skipped. (Note: if you do not want this, just make a temporary annotation with the begin/end/type you want, and don't add it to the index; it will never be found while iterating.) How does creating a temporary annotation disable identical annotations not being skipped, in particular if the temporary annotation shouldn't even be added to the index? I guess I'll revert the changes in uimaFIT v3 related to UIMA-5869 as well. -- Richard
