[ 
https://issues.apache.org/jira/browse/UIMA-5869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806800#comment-16806800
 ] 

Marshall Schor edited comment on UIMA-5869 at 4/1/19 2:54 PM:
--------------------------------------------------------------

This fix has broken existing implementations which test for particular 
exception classes to be thrown.

I'm going to defer fixing this for now.  It probably should eventually be 
fixed, because both the JCas and JCasImpl classes state (and have for a long 
time) that the getView method throws CASException - so anyone relying on this 
will be mislead. 

Will revisit when we have other reasons to bump the version number by the 2nd 
digit.


was (Author: schor):
This fix has broken existing implementations, for little or no added benefit.  
Reverse it, and instead update the javadocs (which I think will not break 
anything).

> The JCas getView method throws CasRuntimeException not CasException
> -------------------------------------------------------------------
>
>                 Key: UIMA-5869
>                 URL: https://issues.apache.org/jira/browse/UIMA-5869
>             Project: UIMA
>          Issue Type: Bug
>          Components: Core Java Framework
>    Affects Versions: 2.10.2SDK, 3.0.0SDK
>            Reporter: Burn Lewis
>            Assignee: Marshall Schor
>            Priority: Minor
>             Fix For: 3.1.0SDK, 2.10.4SDK
>
>
> Code that uses JCas getView expects CasException to be thrown if a view is 
> missing, but instead the underlying CAS.getView method throws 
> CasRuntimeException.
> Either the code or the Javadocs should be fixed.  Since a missing view is not 
> uncommon, throwing an unchecked exception is not very useful.  Making the 
> framework code match the Javadocs should have tminimal impact on existing 
> user code.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to