While reviewing the changes, I see "xmlunit" dependency was added to uimaj-parent pom.
This is used to compare xml outputs, I believe. It looks like it has a license (a BSD form) which I think might require updating all the licenses / (maybe notices) for both source and binary distr. There are other xmlunit implementations that are under the apache 2.0 license, e.g. search maven for org.xmlunit:... (instead of xmlunit:xmlunit). Some of the xml comparison code uses that version. I think some uses of the xmluint:xmlunit might have leaked into other modules, so a review might be needed, to convert these. -Marshall ============== Other unit tests use some xml compare routine - could that one be used instead? -Marshall On 4/23/2020 5:45 PM, GitBox wrote: > reckart opened a new pull request #38: > URL: https://github.com/apache/uima-uimaj/pull/38 > > > * [UIMA-6200] Constructing aggregate engines is slow > * [UIMA-6187] add eol=lf for .sh files > * [UIMA-6128] hook up xcas-1-1 to save > > > ---------------------------------------------------------------- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > >
