mischor commented on a change in pull request #39: URL: https://github.com/apache/uima-uimaj/pull/39#discussion_r420870353
########## File path: uimaj-core/src/main/java/org/apache/uima/pear/util/XMLUtil.java ########## @@ -828,4 +862,18 @@ public static void printXMLTag(String tag, Properties attributes, PrintWriter oW oWriter.print('>'); oWriter.flush(); } + + private static String xmlEscape(String value) + { + if (value == null) { + return value; + } + + return value + .replace("&", "&") Review comment: So, your point is that this xml cleanup code is only used within the Pear context, where it would not be reasonable for anyone to have inputted the & char in an attempt to escape something? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org