jerqi commented on code in PR #9:
URL: https://github.com/apache/incubator-uniffle/pull/9#discussion_r912459521
##########
common/src/main/java/com/tencent/rss/common/config/RssConf.java:
##########
@@ -581,6 +581,11 @@ public <T> RssConf set(ConfigOption<T> option, T value) {
return this;
}
+ public RssConf set(String key, String value) {
Review Comment:
We can reuse method `setString`.
##########
common/src/main/java/com/tencent/rss/common/config/RssConf.java:
##########
@@ -576,7 +576,7 @@ public <T> Optional<T> getOptional(ConfigOption<T> option) {
return value;
}
Review Comment:
````
public <T> Optional<T> getOptional(ConfigOption<T> option) {
Optional<Object> rawValue = getRawValueFromOption(option);
Class<?> clazz = option.getClazz();
Optional<T> value = rawValue.map(v -> option.convertValue(v, clazz));
return value;
}
```
This is the RssConf's implement. Why do we implement the case like
conf.set(listStringOption, List("a", "b", c))?
It's not consistent with others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
