pan3793 commented on PR #13: URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1173735546
> but upgrading gRPC is not very good, because client and server in product environment are not easy to be upgraded simultaneously I don't see a causal relationship between them. If you want a seamless upgrade, you should build a compatibility test to make sure your client and server can work w/ each other in different versions, rather than pin a library version and never do upgrading. Actually, in my experience, the larger the upgrade version span, the greater the risk. The upgrading has a clear request to add native support for Apple Silicon, even w/ no urgent requests, keeping the library update-to-dated is a good practice. > Uniffle can run on Apple M1 by using x86_64 JVM with Rosetta2 In our testing, building Spark using Rosetta2 costs 2 times time more than native. Native is always the first choice. > And can you run `mvn package -Pspark2` and `mvn package -Pmr` Yes, I'm trying. But I think it's not a blocker for mering this one. The CI shows it does not break the current functionalities. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
